Rewrote MrmGetFilePathFromName for clarity/robustness and expanded search to include exe path even with a baseDir #4965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arch to include exe path even with a baseDir
JesseCol
reviewed
May 27, 2025
| break; | ||
| case SearchPass::ParentPathForFileName: | ||
| // move to parent folder of previous search | ||
| RETURN_IF_FAILED(PathCchRemoveFileSpec(searchDir, searchDirCount)); |
There was a problem hiding this comment.
Seems like searchDir and searchDir count will always be zero here since they are both local to the loop body scope?
|
It seems important that we don't accidentally change the logic later -- is it possible to add a test case somewhere? |
JesseCol
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work supports A/B runtime selection